-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Various updates to the Release CI RLlib #36883
[RLlib] Various updates to the Release CI RLlib #36883
Conversation
Signed-off-by: Avnish <avnishnarayan@gmail.com>
CI doesn't build ray wheel if you change only files under release. Maybe change something in rllib and undo it later to trigger the ray wheel. |
hopefully that fixes the wheel problem? |
…gle node Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@@ -73,7 +73,7 @@ def set_cluster_env(self, cluster_env: Dict[str, Any]): | |||
self.cluster_env_name = ( | |||
f"{self.project_name}_{self.project_id[4:8]}" | |||
f"__env__{self.test.get_name().replace('.', '_')}__" | |||
f"{dict_hash(self.cluster_env)}" | |||
f"{dict_hash(self.cluster_env)}__2164728348" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this magic number? a timestamp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@can-anyscale suggested I do this for getting cluster envs to rebuild properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that you did not answer my question :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the number in our bank account in 2 years, let's move fast!
@aslonnie just told me that we have stopped building anyscale/ray-ml:nightly-py37 since 15 days ago so it's critical that all ml release tests need to migrate to py38 at this point, cc: @krfricke Since the branch cut is tomorrow, let's finish this today or tomorrow so we have proper release test signals during branch cut |
Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Signed-off-by: Avnish avnishnarayan@gmail.com
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.